Issue with Weathermap PLugIn 1.0x

[Rno]

So i start to test the 1.0 new plugin of weathermap, and i think their is something witht he way it handle the ICON definition on a Node

My node are define like that (example)

Code: Select all

NODE SRE-VBB-30m1
        LABEL SRE-VBB-30 m1
        INFOURL /cacti/graph.php?rra_id=all&local_graph_id=37447
        OVERLIBGRAPH /cacti/graph_image.php?rra_id=0&graph_nolegend=true&graph_height=100&graph_width=300&local_graph_id=
37447
        ICON 50 50 images/c3bv.png
        TARGET gauge:{map:cacti_path_rra}/sre-vbb-30_vss_status_module1_45237.rrd:VSS_Status_module1:-
        LABELOFFSET 0 -35
        POSITION 1300 150

But I have many error on the log about the ICON, and the path give the '50 50 images/c3bv.png'
05/01/2023 15:08:39 - WEATHERMAP WARNING: ICONFILE file not found on disk: /usr/share/cacti/plugins/weathermap/50 50 images/c3bv.png skipping! [WMPOLL12]

[TheWitness]

The upgrade script is supposed to move these assets to "objects/blah.png", check to see if it moved the object but did not update the record. You might just have to re-edit the map and locate the object. Might be easier to fix it that way for now. All assets should be moved to either images/backgrounds or images/objects.

[Rno]

Ok, So I had to start almost from scratch.
I take my image from the production, but I relpace the whole weathermap directory.

Thirst thing I can't see my map, I can edit insode the editor, but under the tab I have nothing.
in the cacti log i have this:
05/01/2023 17:08:51 - WEATHERMAP WARNING: ICONFILE file not found on disk: /usr/share/cacti/plugins/weathermap/50 50 nink skipping! [WMPOLL12]

The nink image what the ying/yang circle, was not an icon images, but I think it was emended inside weathermap
I have no clue if it's the cause of it, but I have no other error anywhere

Also in th editor, I can't change the editor settings, I ty to view the overlay, but then I can't change back to no, and nothing is visible. And when I go back to cacti, and come back again, the setting is back to default.

Know I have to change my INFOURL, OVERLIBGRAPH and TARGET to see how it works.

I'll be back

[TheWitness]

Post real bugs into Cacti's GitHub. I guess I need to make the Upgrade process a CLI too. Let me think about that.

[Rno]

There is no 'Issue' on your github page about wathermap (https://github.com/TheWitness/plugin_weathermap)

About the upgrade script, you provide a little PHP to upgrade the plugin (inside the general information about your request looking for beta tester), but since I did mine the hard way (start over) I can't test it anymore, but it's seams ok. So maybe a few line inside the README will be sufficient for the test

[Rno]

I add a second map to my config.

So know on the weathermap tab I have the multiple choice, and I can see the small image of both maps.
And Only one of them is available when I click on it, not the other.

What's the difference the one with the most object can't be loaded:
Bigger one (can't display)
116 NODE
80 LINK

Smaller (can display)
55 NODE
28 LINK

But otherwise both have same definition, same structure.
the bigger one has a size of 1900*900
the other 1800x1200

Of curse both has issue about missing file or object ( I didn't finish to update that info yet)
The map id is correct, the file exist, and is readable.
I try to take the small file, and copy it with the name of the big one, so I was expecting to see both (since their the same)
But it doesn't work.

[Rno]

So I find something, at least the block who give me error from my config:

Code: Select all

LINK SE-DC-1-lsa01-Extranet
        ZORDER 350
        BWSTYLE Angled
        INFOURL /cacti/graph.php?rra_id=all&local_graph_id=8653
        NOTES FW Extranet
        OVERLIBGRAPH /cacti/graph_image.php?local_graph_id=8653&rra_id=0&graph_nolegend=true&graph_height=100&graph_width=300
        INBWFORMAT {link:this:bandwidth_in:%k} ({link:this:inpercent:%.1f}%)
        OUTBWFORMAT {link:this:bandwidth_out:%k} ({link:this:outpercent:%.1f}%)
        BWLABELPOS 75 28
        TARGET /usr/share/cacti/rra/se-dpdp-61_traffic_in_8831.rrd
        NODES SE-DC-1 lsa01-DC

LINK SE-DC-0-lsa02-Extranet
        ZORDER 350
        BWSTYLE Angled
        INFOURL /cacti/graph.php?rra_id=all&local_graph_id=8640
        NOTES FW Extranet
        OVERLIBGRAPH /cacti/graph_image.php?local_graph_id=8640&rra_id=0&graph_nolegend=true&graph_height=100&graph_width=300
        INBWFORMAT {link:this:bandwidth_in:%k} ({link:this:inpercent:%.1f}%)
        OUTBWFORMAT {link:this:bandwidth_out:%k} ({link:this:outpercent:%.1f}%)
        BWLABELPOS 75 30
        TARGET /usr/share/cacti/rra/se-dch9-60_traffic_in_8818.rrd
        NODES SE-DC-0 lsa02-DC

In my browser I can see this lines at the end of the page (it's suppose to be html coded)

Code: Select all

FW Extranet data-caption="SE-DC-1-lsa01-Extranet" shape="rect" coords="1472,217,1528,238" /> FW Extranet data-caption="SE-DC-1-lsa01-Extranet" shape="rect" coords="1472,95,1528,116" /> FW Extranet data-caption="SE-DC-1-lsa01-Extranet" shape='poly' coords='1500,40,1504,40,1504,166,1504,166,1500,170,1496,166,1496,166,1496,40,1500,40' /> FW Extranet data-caption="SE-DC-1-lsa01-Extranet" shape='poly' coords='1500,300,1496,300,1496,174,1496,174,1500,170,1504,174,1504,174,1504,300,1500,300' /> FW Extranet data-caption="SE-DC-0-lsa02-Extranet" shape="rect" coords="1472,668,1528,689" /> FW Extranet data-caption="SE-DC-0-lsa02-Extranet" shape="rect" coords="1472,785,1528,806" /> FW Extranet data-caption="SE-DC-0-lsa02-Extranet" shape='poly' coords='1500,860,1496,860,1496,734,1496,734,1500,730,1504,734,1504,734,1504,860,1500,860' /> FW Extranet data-caption="SE-DC-0-lsa02-Extranet" shape='poly' coords='1500,600,1504,600,1504,726,1504,726,1500,730,1496,726,1496,726,1496,600,1500,600' /> 

And after this line everything is screw up.

And the HTML code for this part is:

Code: Select all

<area id="LINK:L176:3" class="link" href="/cacti/graph.php?rra_id=all&local_graph_id=8640" data-hover="<ul class='wm_container'><li class='wm_child'><img style='width:450pxwidth:150px;' src='/cacti/graph_image.php?local_graph_id=8640&rra_id=0&graph_nolegend=true&graph_height=100&graph_width=300&random=40935'></li></ul>"<br>FW Extranet data-caption="SE-DC-0-lsa02-Extranet" shape="rect" coords="1472,668,1528,689" />

But a working line should be:

Code: Select all

<area id="LINK:L160:3" class="link" href="/cacti/graph.php?rra_id=all&local_graph_id=8445" data-hover="<ul class='wm_container'><li class='wm_child'><img style='width:450pxwidth:150px;' src='/cacti/graph_image.php?local_graph_id=8445&rra_id=0&graph_nolegend=true&graph_height=100&graph_width=300&random=18564'></li></ul>" data-caption="SR-V-30m1-SR-V-30m2" shape="rect" coords="1272,290,1328,311" />

The difference is just before the data-caption, on the wrong line it's missing a double-quote so it's taken a comment instead of command
The 'FW Extranet' you can see on the HTML code, is based on the line NOTES on the config
Maybe something wrong with how the code is treating the config line

[Rno]

So I dig again, and it's look like it's more a problem when you have two links between the same set of device
In my case I have a core switch whis 2 connections to my firewall (input traffic, output traffic)

As long as the config has only one link it's ok, but as soon I add the second link, it's broken.
the LINK definition is different, but inside this definition the NODES are the same

[TheWitness]

What's coming into your log?

[Rno]

Well that's my problem!
The only thing I can see in the log is missing file or RRD value:
When generating the image:

Code: Select all

09/01/2023 08:30:14 - WEATHERMAP WARNING: [Map 1] RECOLTEV2.conf: Target /usr/share/cacti/rra/sre-vbb-30_traffic_in_13306.rrd doesn't exist. Is it a file? [WMRRD06]
09/01/2023 08:30:14 - WEATHERMAP WARNING: [Map 1] RECOLTEV2.conf: ReadData: NODE SRE-B80-180m1, target: gauge:/usr/share/cacti/rra/sre-b80-180_vss_status_module1_24168.rrd:VSS_Status_module1:- on config line 240 of /usr/share/cacti/plugins/weathermap/configs/RECOLTEV2.conf had no valid data, according to WeatherMapDataSource_rrd
09/01/2023 08:30:14 - WEATHERMAP WARNING: [Map 1] RECOLTEV2.conf: Target /usr/share/cacti/rra/sre-b80-180_vss_status_module1_24168.rrd doesn't exist. Is it a file? [WMRRD06]
09/01/2023 08:30:14 - WEATHERMAP WARNING: [Map 1] RECOLTEV2.conf: ReadData: NODE SRE-B80-180m2, target: gauge:/usr/share/cacti/rra/sre-b80-180_vss_status_module2_24167.rrd:VSS_Status_module2:- on config line 232 of /usr/share/cacti/plugins/weathermap/configs/RECOLTEV2.conf had no valid data, according to WeatherMapDataSource_rrd
09/01/2023 08:30:14 - WEATHERMAP WARNING: [Map 1] RECOLTEV2.conf: Target /usr/share/cacti/rra/sre-b80-180_vss_status_module2_24167.rrd doesn't exist. Is it a file? [WMRRD06]

When displaying the image:

Code: Select all

09/01/2023 08:29:34 - WEATHERMAP WARNING: ICONFILE file not found on disk: /usr/share/cacti/plugins/weathermap/50 50 nink skipping! [WMPOLL12]
09/01/2023 08:29:34 - WEATHERMAP WARNING: ICONFILE file not found on disk: /usr/share/cacti/plugins/weathermap/50 50 nink skipping! [WMPOLL12]
09/01/2023 08:29:34 - WEATHERMAP WARNING: ICONFILE file not found on disk: /usr/share/cacti/plugins/weathermap/50 50 nink skipping! [WMPOLL12]
09/01/2023 08:29:34 - WEATHERMAP WARNING: ICONFILE file not found on disk: /usr/share/cacti/plugins/weathermap/50 50 none skipping! [WMPOLL12]

And nothing in other error log (http. or cacti_stderr.log)

And the image is actually visible, I attach an image of what I can see (zooming out a lot), and you can see the few text at the bottom, and that's causing the issue of the display. And Only happen when I have a second link between same device

I send the image via PM!

[TheWitness]

Can you log this one on GitHub? I've got the image and will dig in, but if you don't log it there, I'll forget. I've fixed a number of bugs tonight, one that does not include this one. So, if the size bit on the image is real, I still have some work to do.